Skip to content

Conversation

@kai687
Copy link
Contributor

@kai687 kai687 commented Jan 30, 2025

🧭 What and Why

The example for batchWriteParams was wrongly constructed. The object in example is used as is (summary/value fields are for the examples field which is different.

🎟 JIRA Ticket: N/A

Changes included:

  • Fix the example property of the batchWriteParams schema

🧪 Test

N/A

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 30, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 9df7a4b1b00d3f71e3b4d632742f7681fbcd07d6
🍃 Generated commit e1290351199fd8445530be9cbe8949585467b99b
🌲 Generated branch generated/fix/batch-example
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1626
go 1623
php 1529
csharp 1451
python 1144
java 1101
ruby 843
swift 769

@kai687 kai687 changed the title fix(specs): remove batch example fix(specs): fix batchWriteParams example Jan 30, 2025
@kai687 kai687 marked this pull request as ready for review January 30, 2025 11:49
@kai687 kai687 requested a review from a team as a code owner January 30, 2025 11:49
@kai687 kai687 requested review from millotp and shortcuts January 30, 2025 11:49
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@millotp millotp merged commit 8f39af9 into main Jan 30, 2025
28 checks passed
@millotp millotp deleted the fix/batch-example branch January 30, 2025 12:41
algolia-bot added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants